Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sentinel value for inheriting parameter slots #605

Merged
merged 51 commits into from
Apr 12, 2023
+530 −217
Merged

Use sentinel value for inheriting parameter slots #605

Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
7f3bc09
Replace None with _Undefined in constructors, and move validation to …
jbednar Feb 11, 2022
8225ae4
Force TimeSampledFn to have a None default
jbednar Feb 11, 2022
6aca386
Reverted numbergen change
jbednar Feb 12, 2022
98cc7c8
Changed validation to accept _Undefined instead of being deferred
jbednar Feb 12, 2022
df0c9f7
Minor cleanup
jbednar Feb 12, 2022
c776609
Renamed _Undefined to Undefined
jbednar Feb 12, 2022
ce9b249
Replaced un() with _slot_defaults + getattribute
jbednar Feb 16, 2022
20215a4
Added support for callable default values
jbednar Mar 16, 2022
4633477
Merge branch 'main' into undefined
maximlt Feb 20, 2023
0ad7368
make dict_update private
maximlt Feb 20, 2023
5978e38
remove unused and broken check
maximlt Feb 20, 2023
8d5b095
set slot defaults for String
maximlt Feb 21, 2023
86e8d85
move _dict_update to parameterized
maximlt Feb 21, 2023
cd2537a
add _slots_defaults to Bytes
maximlt Feb 21, 2023
73a2d4b
update slot defaults of the direct super class
maximlt Feb 21, 2023
42266e7
update the docstring to refer to Undefined
maximlt Feb 21, 2023
208356f
update Bytes parameter to use the sentinel
maximlt Feb 21, 2023
9e95d28
make allow_None_default private
maximlt Feb 21, 2023
3d87987
Merge branch 'main' into undefined
maximlt Mar 12, 2023
cc6b1da
refactor setting allow_None
maximlt Mar 14, 2023
107df6f
refactor setting instantiate
maximlt Mar 14, 2023
5f28ac5
Merge branch 'main' into undefined
maximlt Mar 14, 2023
538e826
clean up
maximlt Mar 15, 2023
2379afb
fix comparison with Undefined
maximlt Mar 15, 2023
2298f03
undo FileSelector changes
maximlt Mar 15, 2023
8b5a5e0
re-set signature of Bytes
maximlt Mar 15, 2023
8fb5f09
all slots must have a default value
maximlt Mar 15, 2023
1077f2c
Merge branch 'main' into undefined
maximlt Mar 16, 2023
dd634a6
dynamic update of Tuple length
maximlt Mar 16, 2023
f765b56
define Selector default values
maximlt Mar 16, 2023
88f9a9d
define List default values
maximlt Mar 16, 2023
d1c44aa
fix List inheritance
maximlt Mar 16, 2023
15c3cd6
fix comments
maximlt Mar 16, 2023
1211088
update Number behavior test
maximlt Mar 16, 2023
3d9f6fd
fix Selector behavior and adjust tests
maximlt Mar 16, 2023
854a8cb
adjust tuple tests
maximlt Mar 16, 2023
59843b2
adjust parameterized tests
maximlt Mar 16, 2023
5175ad0
Merge branch 'main' into undefined
maximlt Mar 17, 2023
b522d4a
set Tuple length when default is provided
maximlt Mar 17, 2023
953edb4
raise when Undefined is compared
maximlt Mar 17, 2023
576e079
raise better error when a slot has no default value
maximlt Mar 17, 2023
c021efe
Apply suggestions from code review
jbednar Mar 25, 2023
58c688c
rename to _compute_length_of_default
maximlt Apr 4, 2023
f294b57
apply suggestion and rename
maximlt Apr 4, 2023
03b9f4c
rename selector default function
maximlt Apr 4, 2023
8a3e4f2
Merge branch 'main' into undefined
maximlt Apr 4, 2023
81cd1b4
validate the default attribute of Boolean
maximlt Apr 4, 2023
68b6e01
add __repr__ to Undefined
maximlt Apr 11, 2023
2e19f34
improve docs on inheritance
maximlt Apr 11, 2023
9e3f2a9
add docstring to _compute_selector_default
maximlt Apr 11, 2023
0ca0042
add comment on empty_default
maximlt Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into undefined
@maximlt
maximlt committed Mar 14, 2023
commit 5f28ac51ebe3c1477b4f0e03aadca5f8efe3f3be

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.