Patch ghost events from button and relative_rotary resources #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified by comparing the behavior of my production setup to that of a development setup with custom aiohue. |
marcelveldt
reviewed
Jul 21, 2024
marcelveldt
reviewed
Jul 21, 2024
|
That wouldn't work. `button_report` is inside the `button` 'feature'
object. Only `last_event` inside the `button` 'feature' object is
deprecated. See
https://developers.meethue.com/develop/hue-api-v2/api-reference/#resource_button__id__get.
The same applies to `rotary_report`.
…On Mon, Jul 22, 2024 at 12:29 AM Marcel van der Veldt < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In aiohue/v2/controllers/base.py
<#377 (comment)>
:
> return
if self.item_type == ResourceTypes.RELATIVE_ROTARY and not evt_data.get(
- "relative_rotary"
- ):
+ "relative_rotary", {}).get("rotary_report"):
⬇️ Suggested change
- "relative_rotary", {}).get("rotary_report"):
+ "rotary_report"):
—
Reply to this email directly, view it on GitHub
<#377 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANBTFXVTJBXREPVTG4ECWTZNQY6BAVCNFSM6AAAAABLF35QXKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJQGQYDSMRRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yeah you're right - I was not fully awake. As there is no real clean way to do this otherwise, lets just do it this way. |
|
This seems to finally fix the ghost events after an update of the hub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is not a proper fix as it is now dropping the event from button resources when
buttonorbutton.button_report(orrelative_rotaryorrelative_rotary.rotary_reportfor relative_rotary resources) are absent, while there might be other changes in the event that are relevant upstream. Since there was already code to drop the events, I expect the additional condition isn't going to hurt functionality. This should at least make the problem go away.