Remove use of deprecated last_event for button events

[idekker]

Use button_report.event instead.

[idekker]

Fixes home-assistant/core#123282

[idekker]

Could borrow a FoH switch and successfully tested the fix

[Asom-Velz]

@idekker Sorry for the question but in the section Assignees says No one assigned.
I don't have knowledge of how the pull requests are working but should not be mentioned the code owners there (balloob & marcelveldt) ?

[idekker]

@Asom-Velz Not sure what is wrong. Checks complains about no labels being assigned, but I cannot do that. I guess one of the owners will pick it up when they're available.
Depending on how you've setup HA, you can temporarily use my aiohue branch. I'm running the container and simply add a folder share to a locally checked out version of aiohue: <local path to aiohue dir in aiohue clone>:/usr/local/lib/python3.12/site-packages/aiohue

[idekker]

@marcelveldt Please help to review this PR. Many are waiting for events from Friends of Hue switches to be fixed.

[marcelveldt]

@marcelveldt Please help to review this PR. Many are waiting for events from Friends of Hue switches to be fixed.

Not so cool to ping like this. I'm still on holiday. I had planned to pick this up on Monday.

[idekker]

I saw you're actively pushing to music-assistant, so I thought you're back already and you mentioned before a PR would be reviewed if someone could make a fix...

[marcelveldt]

I saw you're actively pushing to music-assistant, so I thought you're back already and you mentioned before a PR would be reviewed if someone could make a fix...

hehe, well, in holiday mode it means I'm doing LESS open source work, not NO open source work :-)
But I'm back, picking up my backlog!

[marcelveldt]

This is fine like this. It will only cause issues for folks that didn't update their Hue bridge for a very long time but imo that is an edge case safe to ignore in this case.

[marcelveldt]

Thanks for the fix @idekker !
Any more fixes you want me to look at now or should we just bump the lib now ?

[idekker]

Not for aiohue. I found another use of the deprecated last_event for relative rotary in the HA integration, but for as long it is not remove it doesn't break anything for anyone.

Ah, yeah, backwards compatibility. Maybe an idea to add button_report to the event when (just) last_event is there. Then at least upstream code doesn't have to deal with deprecated stuff anymore.

[marcelveldt]

Thanks for your help. Feel free to ping me on discord next time you need my help and I'm not responding. Its sometimes hard to get track of the dozens of repositories I'm involved with.

[Asom-Velz]

Hi @idekker @marcelveldt

Thank you both for your efforts to fix this issue.

I have a question what is the time frame that this fix will pop-up as an update to Home Assistant cause some integrations start to require the latest HA version 2024.8 in order to upgrade but I am stuck with the HA version 2024.7.3 which is still working with the FoH switches !!

Regards

[idekker]

I see a tag is created already, but not yet integrated in HA core. I'll see if I can create a PR for it tonight.

[Asom-Velz]

@idekker
Ok Thank you for the info 👌