Backwards compatibility handling on last_event for button and relative_rotary #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idekker
force-pushed
the
last_event_backwards_compatibility
branch
from
f7a95ad
to
30d925f
Compare
|
I like the fact that you added some tests but I';m not sure if we really need to be deprecated reports. In my experience, users are either running the EOL v1 bridge or a up-to-date V2 bridge. This change with the button events is already in the Hue firmware since about a year so I think we're passed the station where we actually still need to be backward compatible. |
|
I agree. If they are not running recent firmware they'll also miss other features and support for newer devices. |
|
Thanks! |
|
As discussed, closing this one and created #419 with just the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to handle the case where the bridge only emits the deprecated
last_eventproperty and notbutton_report(orrelative_rotary). Also created a test for it.I do wonder whether this code has to move to the
ButtonController(andRelativeRotaryController) class before_handle_eventon the base class is called, including the code that drops update-events that do not have a report. But I'm not sure if any of the code that is aftersuper()._handle_event(...)is still relevant even if we decided not to inject the event/new resource upstream.