Add support for Gen3 devices #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bieniu
commented
Dec 1, 2023
| @@ -175,7 +177,6 @@ | |||
| MODEL_PRO_2_V3: "Shelly Pro 2", | |||
| MODEL_PRO_2PM: "Shelly Pro 2PM", | |||
| MODEL_PRO_2PM_V2: "Shelly Pro 2PM", | |||
| MODEL_PRO_2PM_V2: "Shelly Pro 2PM", | |||
thecode
reviewed
Dec 2, 2023
chemelli74
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API for generation 3 is practically the same as for generation 2, so only minor changes are needed here.
I tested this change with gen1, gen2 and gen3 devices and see no problems.