Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gen1 minimum firmware version to 1.11.0 (2021-07-15) #460

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

bieniu
Copy link
Collaborator

@bieniu bieniu commented Dec 2, 2023

Due to many fixes and new functionalities introduced in subsequent firmware versions, the minimum firmware version supported by aioshelly is increased to 1.11.0 (2021-07-15). This release included the last major change in API functionality (transition for lights).

Changelog: https://shelly-api-docs.shelly.cloud/gen1/#changelog

@bieniu
Copy link
Collaborator Author

bieniu commented Dec 2, 2023

Same question, should we mark this as breaking change?

Copy link
Contributor

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does firmware 1.13.0 brings that older firmware doesn't support?
This is a relatively new firmware, while in Gen2 which is a new device it is make sense to enforce minimum version, we should have a good reason to enforce users to upgrade firmware for old devices which most of them are out of warranty and not sold anymore.

As for Motion, I am still using version 2.18 since I had WIFI problems with 2.19.

@bieniu bieniu marked this pull request as draft December 3, 2023 13:13
@bieniu
Copy link
Collaborator Author

bieniu commented Dec 3, 2023

OK, maybe I was too strict with the version number.

Therefore I suggest using version 1.11.0 (2021-07-15 according to the documentation) as the minimum version for gen1, this version introduced transition for lights.

I don't remember why in the code the date for 1.11.0 is 2021-02-26 (maybe this was a beta?)
https://github.com/home-assistant/core/blob/c8bb72935d935680ea7a9c5f8bde552f2d8f7dcd/homeassistant/components/shelly/const.py#L36-L37

What do you think?

@thecode
Copy link
Contributor

thecode commented Dec 3, 2023

OK, maybe I was too strict with the version number.

Therefore I suggest using version 1.11.0 (2021-07-15 according to the documentation) as the minimum version for gen1, this version introduced transition for lights.

Sounds great

I don't remember why in the code the date for 1.11.0 is 2023-02-26 (maybe this was a beta?) https://github.com/home-assistant/core/blob/c8bb72935d935680ea7a9c5f8bde552f2d8f7dcd/homeassistant/components/shelly/const.py#L36-L37

What do you think?

Looking at the timeline of the releases I assume it was a pre-release firmware we tested. I downgraded a bulb (SHCB-1) to v1.11.0 using Firmware Archive Link Generator and it is dated 20210720-184102/v1.11.0-g6abd92e. I assume the few days difference is due the time it was released to the time it was actually built.

We can use 2021-07-15 as mentioned in the changelog, I think we should also add this in the PR description that the minimum is set this version that supports transitions.

@bieniu bieniu changed the title Bump Gen1 minimum firmware version to 1.13.0 (2023-05-03) Bump Gen1 minimum firmware version to 1.11.0 (2021-07-15) Dec 3, 2023
@bieniu bieniu added the breaking-change Breaking changes label Dec 3, 2023
@bieniu bieniu marked this pull request as ready for review December 3, 2023 22:14
@chemelli74
Copy link
Collaborator

OK, maybe I was too strict with the version number.

Therefore I suggest using version 1.11.0 (2021-07-15 according to the documentation) as the minimum version for gen1, this version introduced transition for lights.

Sounds great

I don't remember why in the code the date for 1.11.0 is 2023-02-26 (maybe this was a beta?) https://github.com/home-assistant/core/blob/c8bb72935d935680ea7a9c5f8bde552f2d8f7dcd/homeassistant/components/shelly/const.py#L36-L37

What do you think?

Looking at the timeline of the releases I assume it was a pre-release firmware we tested. I downgraded a bulb (SHCB-1) to v1.11.0 using Firmware Archive Link Generator and it is dated 20210720-184102/v1.11.0-g6abd92e. I assume the few days difference is due the time it was released to the time it was actually built.

I got lost, as code there was a reference to 2023-02-06 and one to 2021-07-20; how is just a few days ?

@bieniu
Copy link
Collaborator Author

bieniu commented Dec 3, 2023

The date in the code is 2021-02-06, not 2023, I made a typo.
When comparing firmware for different devices, the dates range is from 2021-07-15 to 2021-07-21 if I remember correctly.

Copy link
Contributor

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bieniu bieniu merged commit e888393 into main Dec 9, 2023
3 checks passed
@bieniu bieniu deleted the min-fw-ver-gen1 branch December 9, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants