Trigger OTA for not initialized devices #485
Conversation
|
Honestly, I think we should drop this, we enforced minimum firmware version to reduce our code maintenance efforts and end up with complicated code to now workaround about firmware update problems |
|
I still think we should not go forward with this, the added complexity doesn't worth the benefit. If we complicated the code so much, I would rather go back to were we was in core 2023.12 before we introduced the minimum firmware requirement (which was meant to reduce code complexity and not increase it. Auth for Gen2 will not work as implemented here since Gen2 uses digest, if we have to duplicate this logic for HTTP we now increase the code that we have to maintain backward compatibility. |
| try: | ||
| await session.get( | ||
| URL.build(scheme="http", host=host, path=f"/{path}"), | ||
| auth=auth, |
There was a problem hiding this comment.
This will fail if used for Gen2
There was a problem hiding this comment.
To avoid complexity of the code, we should move the Auth management out of the class so to reuse it here and there
There was a problem hiding this comment.
The auth code is part of a class so you would have to do many changes for this and you end up with a code that was supposed to serve for wsrpc under common while it is nothing in common with Gen1.
I really don't understand were you are going with it. We enforce a minimum version which blocks us from initializing a device (although any minimum you set for Gen2 will not block you from initializing the device since there are no breaking API changes) than we move code to common so we can talk to the device without initializing it while we shouldn't have gone there in the first place.
chemelli74
force-pushed
the
chemelli74-indipendent-ota
branch
from
14eff07 to
e8b0fb7
Compare
|
Superseded by #544 |
Allow OTA to work for devices that are not initialized.
This will be used in HA for repairing an unsupported firmware for connected devices.