Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MacAddressMismatchError check for RPC devices #715

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

thecode
Copy link
Contributor

@thecode thecode commented Nov 16, 2024

Fixes regression found at home-assistant/core#130696

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 38.60%. Comparing base (7105bec) to head (b837b3d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
aioshelly/rpc_device/device.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   38.71%   38.60%   -0.11%     
==========================================
  Files          15       15              
  Lines        1444     1448       +4     
==========================================
  Hits          559      559              
- Misses        885      889       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great catch!

@thecode
Copy link
Contributor Author

thecode commented Nov 17, 2024

Thanks

@thecode thecode merged commit 503d43c into main Nov 17, 2024
3 of 5 checks passed
@thecode thecode deleted the rpc-mac-check branch November 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants