Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all response pages for Shelly.GetComponents #722

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bieniu
Copy link
Collaborator

@bieniu bieniu commented Nov 25, 2024

Fixes #674

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 38.50%. Comparing base (5eabe52) to head (351f0f7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
aioshelly/rpc_device/device.py 13.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   38.68%   38.50%   -0.19%     
==========================================
  Files          15       15              
  Lines        1450     1462      +12     
==========================================
+ Hits          561      563       +2     
- Misses        889      899      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bieniu bieniu marked this pull request as ready for review November 27, 2024 10:14
@chemelli74
Copy link
Collaborator

I think the approach is fine.

@bieniu bieniu force-pushed the dynamic-components-multi-pages branch from a30b61c to 351f0f7 Compare November 27, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On large number of Dynamic components, not all are retrived
2 participants