Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging graceful disconnect as error #987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elupus
Copy link
Collaborator

@elupus elupus commented Nov 13, 2024

The chromecasts restart each night, and seem to
generally do this by doing a socket shutdown of
write leading to a EOF received by clients.

No need to log this as an error

The chromecasts restart each night, and seem to
generally do this by doing a socket shutdown of
write leading to a EOF received by clients.

No need to log this as an error
@elupus
Copy link
Collaborator Author

elupus commented Nov 13, 2024

Next step would be to add some backoff on reconnect. Not verified this, but if they behave correctly (which I suspect they do) they remove their mdns entry either before or more likely after they disconnect.

So we should hit the mdns backoff if we delay just a little. But not fully sure how to add that delay.

@elupus
Copy link
Collaborator Author

elupus commented Nov 13, 2024

Hmm. I wonder should we set stop()? Will something restart the thread again when a service is spotted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant