Add remove and download backup location #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agners
approved these changes
Dec 16, 2024
| @@ -135,7 +135,7 @@ class FullBackupOptions(Request): | |||
| name: str | None = None | |||
| password: str | None = None | |||
| compressed: bool | None = None | |||
| location: set[str | None] | str | None = None | |||
| location: list[str | None] | str | None = DEFAULT # type: ignore[assignment] | |||
There was a problem hiding this comment.
Technically, I guess this is a breaking change, but we only introduced set[] support with #33 which isn't in a stable release, so changing that is fine.
There was a problem hiding this comment.
Yea I noted that in the description
This was referenced Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add support for specifying location in remove and download backup APIs as per home-assistant/supervisor#5482
In addition, fixes two issues with the
FullBackupOptionsandPartialBackupOptionsmodels identified as part of this:Nonewas a valid option for location that did not get passed on to Supervisor. Now accepted.locationcannot be aset. Order matters as the first one in the list becomes the primary location of the backup. This is now unfortunately a breaking change to the beta from Cloud backup support #33