Handle non existing result futures on pop (#756)

test/conftest.py

@@ -161,9 +161,11 @@ async def receive():
         """Return a websocket message."""
         await asyncio.sleep(0)
 
-        message = messages.popleft()
-        if not messages:
+        try:
+            message = messages.popleft()
+        except IndexError:
             ws_client.closed = True
+            return WSMessage(WSMsgType.CLOSED, None, None)
 
         return message
 

test/test_client.py

@@ -461,3 +461,18 @@ async def test_additional_user_agent_components(client_session, url):
                 },
             }
         )
+
+
+async def test_pop_future_none(client_session, url, driver_ready):
+    """Test when a future has been cleared from futures dict, popping still works."""
+    client = Client(url, client_session)
+    await client.connect()
+
+    assert client.connected
+
+    asyncio.create_task(client.listen(driver_ready))
+
+    await driver_ready.wait()
+
+    with pytest.raises(asyncio.CancelledError):
+        await client.async_send_command({"command": "some_command"})

test/test_main.py

@@ -72,4 +72,4 @@ def test_connect(client_session, url, ws_client):
         main()
 
     assert sys_exit.value.code == 0
-    assert ws_client.receive.call_count == 4
+    assert ws_client.receive.call_count == 5

zwave_js_server/client.py

@@ -115,7 +115,7 @@ async def async_send_command(
         try:
             return await future
         finally:
-            self._result_futures.pop(message_id)
+            self._result_futures.pop(message_id, None)
 
     async def async_send_command_no_wait(
         self, message: dict[str, Any], require_schema: int | None = None