Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support get_raw_config_parameter_value #1093

Conversation

MindFreeze
Copy link
Contributor

Needed for certification.
Related PR in the JS server zwave-js/zwave-js-server#1300

Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can be merged when the server PR is merged and we've bumped the minimum schema version.

@MindFreeze
Copy link
Contributor Author

Server PR merged an in 1.39.0

@MartinHjelmare
Copy link
Contributor

@MartinHjelmare
Copy link
Contributor

Before we can use the new commands we either need to specify the minimum schema version in the command signature for each new command or bump the minimum schema version in the client.

@MindFreeze
Copy link
Contributor Author

@MartinHjelmare I set require_schema: 39 for the command. Should I bump MAX_SERVER_SCHEMA_VERSION in this PR?

@MartinHjelmare
Copy link
Contributor

Yes, please bump the max version.

@MindFreeze MindFreeze marked this pull request as ready for review October 17, 2024 18:06
Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 4f49baf into home-assistant-libs:master Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants