Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inclusion state changed controller event #1114

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Add inclusion state changed controller event #1114

merged 3 commits into from
Nov 11, 2024

Conversation

MartinHjelmare
Copy link
Contributor

  • We missed adding this controller event when adding support for schema 38.

MartinHjelmare
MartinHjelmare commented Nov 11, 2024
View reviewed changes
Copy link
Contributor Author

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I couldn't get the commit passed pre-commit validation locally, without ignoring mypy for those places.

zwave_js_server/model/controller/__init__.py Outdated Show resolved Hide resolved
zwave_js_server/model/controller/__init__.py Outdated Show resolved Hide resolved
@raman325
Copy link
Contributor

I have that same problem occasionally and I haven't been able to figure out why

@raman325 raman325 merged commit b4fc851 into master Nov 11, 2024
4 checks passed
@raman325 raman325 deleted the add-inclusion-state-changed-controller-event branch November 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raman325 raman325 raman325 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinHjelmare @raman325