Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node.async_set_raw_config_parameter_value command #780

Merged
merged 16 commits into from
Oct 24, 2023

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Oct 15, 2023

Breaking Change

The return value of async_bulk_set_partial_config_parameters and async_set_config_parameter has changed to include both whether the command was accepted immediately or queued, as well as the result if we have it.

Needed for certification (zwave-js/certification-backlog#12). Dependent on zwave-js/zwave-js-server#1068

@raman325 raman325 marked this pull request as draft October 16, 2023 04:20
@raman325 raman325 force-pushed the raw_config_parameter branch from 0af337d to 392c1b2 Compare October 16, 2023 23:56
@raman325 raman325 added the breaking-change Breaking changes label Oct 19, 2023
@raman325 raman325 marked this pull request as ready for review October 20, 2023 16:44
@raman325
Copy link
Contributor Author

@MartinHjelmare any thoughts on this PR? The locks PR is dependent on this one

@MartinHjelmare
Copy link
Contributor

Can you link to the issue that describes the certification requirement? There's no context right now in the PR description.

@raman325
Copy link
Contributor Author

done

Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@raman325 raman325 merged commit 683ec94 into home-assistant-libs:master Oct 24, 2023
4 checks passed
@raman325 raman325 deleted the raw_config_parameter branch October 24, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants