-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node.async_set_raw_config_parameter_value command #780
Merged
raman325
merged 16 commits into
home-assistant-libs:master
from
raman325:raw_config_parameter
Oct 24, 2023
Merged
Add node.async_set_raw_config_parameter_value command #780
raman325
merged 16 commits into
home-assistant-libs:master
from
raman325:raw_config_parameter
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raman325
force-pushed
the
raw_config_parameter
branch
from
October 16, 2023 23:56
0af337d
to
392c1b2
Compare
@MartinHjelmare any thoughts on this PR? The locks PR is dependent on this one |
Can you link to the issue that describes the certification requirement? There's no context right now in the PR description. |
done |
MartinHjelmare
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good!
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
The return value of
async_bulk_set_partial_config_parameters
andasync_set_config_parameter
has changed to include both whether the command was accepted immediately or queued, as well as the result if we have it.Needed for certification (zwave-js/certification-backlog#12). Dependent on zwave-js/zwave-js-server#1068