Switch to ruff in tests and precommit #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New to
ruffso if you wonder why I did something a certain way, I probably didn't have a good reason, I was just experimenting/using HA as a reference while trying to minimize complexity. I fixed some things that ruff caught so that's great.I disabledI re-enabled it without issue and ranwarn_return_anybecause all of a sudden it started spitting out a bunch of errors. Not sure why we didn't see these before? If we want to re-enable it, I can do so in a separate PR, just let me knowmypyto confirm there were no errors, so not sure what happened