Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Soil temperature" property for thermostat #831

Closed
wants to merge 1 commit into from

Conversation

TastyPi
Copy link

@TastyPi TastyPi commented Dec 7, 2023

The HELTUN HE-HT01 thermostat provides both an "Air temperature" and "Soil temperature" property in its CommandClass.SENSOR_MULTILEVEL. I'd like to create a ZWaveDiscoverySchema which displays the correct temperature based on the "Source Sensor" configuration parameter (parameter number 11).

Other code in home-assistant/core uses constants from this lib to refer to properties, so I assume it is best practice to list them here before using them there. Let me know if I'm mistaken.

@TastyPi
Copy link
Author

TastyPi commented Dec 7, 2023

@raman325
Copy link
Contributor

raman325 commented Dec 7, 2023

thanks for your PR! The properties should go here though: https://github.com/home-assistant-libs/zwave-js-server-python/blob/master/zwave_js_server/const/command_class/multilevel_sensor.py

but what makes more sense is probably to update this script to add property constants to make this easier: https://github.com/home-assistant-libs/zwave-js-server-python/blob/master/scripts/generate_multilevel_sensor_constants.py

I'd personally prefer the latter as then we are covered for all of them

@raman325
Copy link
Contributor

raman325 commented Dec 7, 2023

hey so I went ahead and implemented this because these scripts are not architected very well and it would take you a lot longer than it just took me to make the necessary changes. Thank you again though, this was a great idea

@raman325 raman325 closed this Dec 7, 2023
@TastyPi
Copy link
Author

TastyPi commented Dec 8, 2023

@raman325 Thanks for the help! Could I get a new version of this released so I can try contributing the config for my thermostat to homeassistant/core?

@raman325
Copy link
Contributor

raman325 commented Dec 8, 2023

no problem! I have one more PR in flight that we should be able to merge soon and then we can create a release. If it takes longer than a week, just tag me again and we can make a patch release for this one update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants