-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Loopia DNS challenge #3821
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4a0411b
Add support for Loopia DNS challenge
agnon 44c6034
Bump letsencrypt to 5.3.0 instead of 5.2.4
agnon 9e68ed8
Update DOCS.md for Loopia DNS challenge
agnon 7b8202b
Update DOCS.md for Loopia DNS challenge
agnon 5d925e3
Use patch version to add new DNS support
agners File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
# Changelog | ||
|
||
## 5.2.4 | ||
|
||
- Add Loopia DNS support | ||
|
||
## 5.2.3 | ||
|
||
- Fix syntax error in run script | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,7 @@ dns-infomaniak | |
dns-ionos | ||
dns-joker | ||
dns-linode | ||
dns-loopia | ||
dns-luadns | ||
dns-njalla | ||
dns-noris | ||
|
@@ -118,6 +119,8 @@ joker_password: '' | |
joker_domain: '' | ||
linode_key: '' | ||
linode_version: '' | ||
loopia_username: '' | ||
loopia_password: '' | ||
luadns_email: '' | ||
luadns_token: '' | ||
njalla_token: '' | ||
|
@@ -567,6 +570,26 @@ To use this addon with Linode DNS, first [create a new API/access key](https://w | |
|
||
</details> | ||
|
||
<details> | ||
<summary>Loopia</summary> | ||
|
||
To use this addon with Loopia DNS, first [create a new API user](https://customerzone.loopia.com/), with at least addZoneRecord, getZoneRecords, removeZoneRecord and removeSubdomain permissions. | ||
|
||
```yaml | ||
email: [email protected] | ||
domains: | ||
- ha.yourdomain.com | ||
certfile: fullchain.pem | ||
keyfile: privkey.pem | ||
challenge: dns | ||
dns: | ||
provider: dns-loopia | ||
loopia_username: example@loopiaapi | ||
loopia_password: supersecretpasswordhere | ||
``` | ||
|
||
</details> | ||
|
||
<details> | ||
<summary>DirectAdmin</summary> | ||
|
||
|
@@ -1075,6 +1098,7 @@ dns-hetzner | |
dns-infomaniak | ||
dns-ionos | ||
dns-linode | ||
dns-loopia | ||
dns-luadns | ||
dns-njalla | ||
dns-noris | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider bumping minor version instead of patch.
Adding support for a new DNS provider is a feature addition rather than a bug fix. Based on semantic versioning principles and the pattern seen in previous DNS provider additions (e.g., IONOS DNS in 5.2.2), this should be version 5.3.0 instead of 5.2.4.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This add-on used patch version to add new DNS providers, so let's stay consistent and continue with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agners Understood, we'll maintain consistency with the existing versioning scheme.