Widget placeholder UI Improvements (#4649)

* Small UI Improvements * Addressed some comments * Update widget_camera.xml Removed Padding
home-assistant · Sep 22, 2024 · c9ecd44 · c9ecd44
1 parent 6b7bc9c
commit c9ecd44
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 14 deletions.
diff --git a/app/src/main/res/layout/widget_button.xml b/app/src/main/res/layout/widget_button.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/widgetLayout"
     android:layout_width="match_parent"

diff --git a/app/src/main/res/layout/widget_camera.xml b/app/src/main/res/layout/widget_camera.xml
@@ -13,19 +13,27 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:visibility="invisible"
+        android:layout_gravity="center"
         android:adjustViewBounds="true"
         android:contentDescription="@string/widget_camera_contentdescription"
         android:scaleType="fitCenter" />
-    <ImageView
+
+    <FrameLayout
         android:id="@+id/widgetCameraPlaceholder"
         android:layout_width="match_parent"
-        android:layout_height="match_parent"
-        android:layout_marginStart="4dp"
-        android:layout_marginTop="4dp"
-        android:layout_marginBottom="4dp"
-        android:src="@drawable/app_icon_round"
-        android:contentDescription="@string/widget_camera_contentdescription"
-        android:scaleType="fitCenter" />
+        android:layout_gravity="center"
+        android:background="@android:color/transparent"
+        android:layout_height="match_parent">
+
+        <ImageView
+            android:layout_width="48dp"
+            android:layout_height="48dp"
+            android:layout_gravity="center"
+            android:contentDescription="@string/widget_camera_contentdescription"
+            android:scaleType="fitCenter"
+            android:src="@android:drawable/ic_menu_camera" />
+    </FrameLayout>
+
     <ImageView
         android:id="@+id/widgetCameraError"
         android:contentDescription="@string/widget_entity_fetch_error"
@@ -34,5 +42,5 @@
         android:layout_marginBottom="4dp"
         android:src="@drawable/ic_sync_problem"
         android:layout_gravity="center_horizontal|bottom"
-        android:visibility="gone"/>
-</FrameLayout>
+        android:visibility="gone" />
+</FrameLayout>
diff --git a/app/src/main/res/layout/widget_media_controls.xml b/app/src/main/res/layout/widget_media_controls.xml
@@ -33,13 +33,15 @@
                 android:id="@+id/widgetMediaPlaceholder"
                 android:layout_width="wrap_content"
                 android:layout_height="match_parent"
+                android:padding="30dp"
                 android:layout_marginStart="4dp"
                 android:layout_marginTop="4dp"
                 android:layout_marginBottom="4dp"
                 android:contentDescription="@string/widget_media_image_description"
                 android:adjustViewBounds="true"
                 android:scaleType="fitCenter"
-                android:src="@drawable/app_icon_round" />
+                android:tint="?colorWidgetOnBackground"
+                android:src="@android:drawable/ic_media_play" />
         </FrameLayout>
 
         <RelativeLayout

diff --git a/app/src/main/res/xml/entity_widget_info.xml b/app/src/main/res/xml/entity_widget_info.xml
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <appwidget-provider xmlns:android="http://schemas.android.com/apk/res/android"
     android:configure="io.homeassistant.companion.android.widgets.entity.EntityWidgetConfigureActivity"
-    android:initialKeyguardLayout="@layout/widget_button"
-    android:initialLayout="@layout/widget_button"
+    android:initialKeyguardLayout="@layout/widget_static"
+    android:initialLayout="@layout/widget_static"
     android:minWidth="40dp"
     android:minHeight="40dp"
     android:minResizeWidth="40dp"