Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new entity picker for more settings #3662

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Use new entity picker for more settings #3662

merged 1 commit into from
Jul 17, 2023

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Jul 15, 2023 •
edited
Loading

Summary

Use the new entity picker from #3653 for more settings as it provides a better experience.

Screenshots

Light Dark
Shortcuts with entity picker, entity ID was renamed entity to reflect this Shortcut setting with a text field + dropdown for entity instead of a basic button only showing IDs, light mode Shortcut setting with a text field + dropdown for entity instead of a basic button only showing IDs, dark mode
Wear favorite management now uses the entity picker instead of a very long list of all entities with checkmarks Favorite entities screen with 'Add favorite' text field at the top, followed by 3 favorites with a clear and re-order icon button, light mode Favorite entities screen with 'Add favorite' text field at the top, followed by 3 favorites with a clear and re-order icon button, dark mode

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#959

Any other notes

@jpelgrom jpelgrom mentioned this pull request Jul 15, 2023
Merged
dshokouhi
dshokouhi approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@JBassett JBassett merged commit cd62f17 into home-assistant:master Jul 17, 2023
3 checks passed
@jpelgrom jpelgrom deleted the more-new-entity-picker branch July 17, 2023 12:56
@jpelgrom jpelgrom mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBassett JBassett JBassett approved these changes

@dshokouhi dshokouhi dshokouhi approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpelgrom @JBassett @dshokouhi