-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android auto: Switch to GridTemplate for home screen and default to favorites if defined #3694
Android auto: Switch to GridTemplate for home screen and default to favorites if defined #3694
Conversation
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality works (great improvement IMO!), but the code is like spaghetti going back and forth between EntityGridVehicleScreen
and MainVehicleScreen
and hard to understand. Added a few suggestions that I think will make it easier to follow.
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/EntityGridVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/DomainListScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/DomainListScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/DomainListScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/BaseVehicleScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is the best it can be without larger architecture changes. Thanks for your patience, great feature!
Agreed, lets try to take those on in future PRs :)
Thanks for your time reviewing :) |
Summary
The default home screen now uses
GridTemplate
instead ofListTemplate
to allow for more domains and buttons to be shown. My Subaru has a giant 11" screen,ListTemplate
shows a total of 10 items butGridTemplate
shows 15 before needing to scroll.When favorites are defined we will now show the entity grid screen with the user defined favorites. We will also add Navigation, All entities and Change servers (if applicable) to the grid view.
If favorites are defined but user has multiple servers they will continue to see all domains listed
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#964
Any other notes