Android auto: Switch to GridTemplate for home screen and default to favorites if defined #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpelgrom
reviewed
Jul 21, 2023
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
dshokouhi
changed the title
jpelgrom
reviewed
Jul 22, 2023
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/EntityGridVehicleScreen.kt
Outdated
Show resolved
Hide resolved
jpelgrom
reviewed
Jul 24, 2023
app/src/main/java/io/homeassistant/companion/android/vehicle/DomainListScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/vehicle/DomainListScreen.kt
Outdated
Show resolved
Hide resolved
jpelgrom
reviewed
Jul 25, 2023
app/src/main/java/io/homeassistant/companion/android/vehicle/DomainListScreen.kt
Outdated
Show resolved
Hide resolved
jpelgrom
reviewed
Jul 25, 2023
app/src/main/java/io/homeassistant/companion/android/vehicle/BaseVehicleScreen.kt
Outdated
Show resolved
Hide resolved
jpelgrom
approved these changes
Jul 25, 2023
Agreed, lets try to take those on in future PRs :)
Thanks for your time reviewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default home screen now uses
GridTemplateinstead ofListTemplateto allow for more domains and buttons to be shown. My Subaru has a giant 11" screen,ListTemplateshows a total of 10 items butGridTemplateshows 15 before needing to scroll.When favorites are defined we will now show the entity grid screen with the user defined favorites. We will also add Navigation, All entities and Change servers (if applicable) to the grid view.
If favorites are defined but user has multiple servers they will continue to see all domains listed
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#964
Any other notes