Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show application names, not only package names, in sensor settings #3700

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Show application names, not only package names, in sensor settings #3700

merged 1 commit into from
Jul 24, 2023

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Jul 22, 2023 •
edited
Loading

Summary

Fixes #3683 by also showing application names to make it easier to quickly see what is set and find the app you're looking for.

Screenshots

Light Dark
Setting before opening shows app names Sensor setting named 'Allow List' with value 'Clock, Home Assistant, NS, YouTube', light mode Sensor setting named 'Allow List' with value 'Clock, Home Assistant, NS, YouTube', dark mode
Setting dialog shows app names and package names if possible Dialog 'Allow List' listing most apps as "App name (package name)", a few as "Package name", light mode Dialog 'Allow List' listing most apps as "App name (package name)", a few as "Package name", dark mode

Link to pull request in Documentation repository

n/a

Any other notes

dshokouhi
dshokouhi approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Hopefully makes the list more understandable :)

@JBassett JBassett merged commit a0a3c51 into home-assistant:master Jul 24, 2023
3 checks passed
@jpelgrom jpelgrom deleted the sensor-list-apps-names branch July 24, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBassett JBassett JBassett approved these changes

@dshokouhi dshokouhi dshokouhi approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve installed applications list to application names in last notification allow list
3 participants
@jpelgrom @JBassett @dshokouhi