Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version code for F-Droid builds #3717

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jpelgrom
Copy link
Member

Summary

The new release model #3597 removed version_code.txt, which broke F-Droid's update detection. We could tell them to update to use our version names and version.txt but this is easier as this file was specifically added for them.

Screenshots

n/a

Link to pull request in Documentation repository

n/a

Any other notes

@jpelgrom
Copy link
Member Author

Also if this is approved we should upload a version_code.txt for the 2023.7.5 release to be nice :)

@dshokouhi
Copy link
Member

Also if this is approved we should upload a version_code.txt for the 2023.7.5 release to be nice :)

Do we need to wait? Can we just upload one beforehand? Will their build trigger if we edit an existing release?

@jpelgrom
Copy link
Member Author

I don't know if it will trigger a build for them but no harm in adding it?

@dshokouhi
Copy link
Member

I don't know if it will trigger a build for them but no harm in adding it?

ok added it

@jpelgrom
Copy link
Member Author

Version code for app-minimal-release.apk downloaded from that release is 10506, not 10507?

@dshokouhi
Copy link
Member

dshokouhi commented Jul 26, 2023

Version code for app-minimal-release.apk downloaded from that release is 10506, not 10507?

oops thats what I get for looking at the Play Console 😂

Edit: fixed

@JBassett JBassett merged commit 9e61037 into home-assistant:master Jul 27, 2023
3 checks passed
@jpelgrom jpelgrom deleted the fix-version-code-fdroid branch July 27, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants