Add native flow/support for Improv Wi-Fi devices with Bluetooth #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the flow order to ask for Wi-Fi first, then connect and submit, to prevent timeout issues - Keep Wi-Fi details entered intact when pausing/resuming, for example because you opened your password manager app or went searching for a piece of paper - Align sheet step UIs and clean up padding/alignment, extract strings
- Handle permissions - Fix loop with WiFi info on error - Start scanning on IO coroutine to prevent freeze - Make Snackbar show forever and use CoordinatorLayout so user can dismiss it by swiping - Stop scanning when navigating to another page
- Feedback: prefill current SSID - Improve item height - Fix adding exoplayer views
- Feedback: use column for SSID/password - Submit SSID/password when tapping done on keyboard - Implement library updates for result (redirect to domain setup)
- Also adds dependency to automotive build
JBassett
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a native flow to the app to add Improv Wi-Fi devices using the Android device's Bluetooth. This mostly follows the iOS companion app implementation but with a more Android-like UI.
Two minor changes are in this PR which aren't obviously connected to the flow:
WebViewActivitywas changed to give the added Snackbar nice animations and make it possible to swipe to dismiss, which required a few references to be updatedThis PR is submitted as a draft because the app feature is basically complete but I'm waiting for the PRs on the improv-wifi/sdk-android repo to be accepted, and hopefully we can publish the SDK instead of including an aar file. The aar file added right now is a local build of the SDK with all my PR changes included.Changes merged and library published to Maven Central.Screenshots
The following video shows the flow:
improvflow1002-1.mp4
When tapping the frontend option to add a device, permission dialogs are shown if required (depending on Android version and what permissions the app already has), and if granted the app starts scanning in the background. If any devices are found a Snackbar will be shown. Tapping on the configure action, like frontend found devices, will trigger a sheet/dialog to select the device, enter your Wi-Fi credentials, and connect and configure. When done tapping Continue will redirect to setup that integration in the frontend.
Link to pull request in Documentation repository
n/a
Any other notes