Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package name to health connect sensors, additional sensor tweaks #4750

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

dshokouhi
Copy link
Member

Summary

  • update weight icon to be more correct
  • Add state class total increasing for total calories as the sensor resets at midnight and accumulates until then
  • Add package as an attribute so users can understand from where the data came from

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the attribute should be package or if source makes more sense for less technical users 🤔

Other changes look good to me

@jpelgrom
Copy link
Member

Also, was Health Connect approved? Or is this just cleaning it up in case it is like the other cleanups we've done?

@dshokouhi
Copy link
Member Author

I'm not sure the attribute should be package or if source makes more sense for less technical users 🤔

hmm source feels more correct I think I will update

@dshokouhi
Copy link
Member Author

Also, was Health Connect approved? Or is this just cleaning it up in case it is like the other cleanups we've done?

not yet 😭 , just clean ups that I have thought of and didnt want to forget :)

@dshokouhi dshokouhi merged commit 751e250 into home-assistant:master Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants