Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support behavior: textInput key on notification action for reply actions #4763

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support behavior: textInput key on notification action for reply actions #4763

wants to merge 3 commits into from
+9 −5

Commits on Oct 29, 2024

  1. Include notification action title in event data for reply actions

    @jpelgrom
    jpelgrom committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    fe6941e View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Support behavior: textInput 

     - Instead of adding a new key, allow using the behavior: textInput key which already works on iOS to trigger the reply notification action
    @jpelgrom
    jpelgrom committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a92bd8c View commit details
    Browse the repository at this point in the history

  2. Check in lowercase 

     - Matches iOS behavior in https://github.com/home-assistant/iOS/blob/f52351e4c9ddaff8f4722b1d3849d63746653821/Sources/Shared/API/Models/NotificationAction.swift#L34
    @jpelgrom
    jpelgrom committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    797bc98 View commit details
    Browse the repository at this point in the history