Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CSP Frame Ancestors in android-webview.md #781

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t-animal
Copy link

Include hint how to set up CSP Frame Ancestors directive in android webview documentation. Without this, it can be quite hard to figure out the origin to allow without remote debugging the webview.

Include hint how to set up CSP Frame Ancestors directive in android webview documentation. Without this, it can be quite hard to figure out the origin to allow without remote debugging the webview.
@homeassistant
Copy link
Contributor

Hi @t-animal,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@jpelgrom
Copy link
Member

Wouldn't this also apply to the iOS app, and make more sense on the troubleshooting page?

@t-animal
Copy link
Author

t-animal commented Jul 24, 2022

Possibly, but I don't know. I don't know exactly how the companion app and iOS webview works. I wouldn't move it there without confirmation, because no documentation is better than incorrect documentation.

@jpelgrom
Copy link
Member

@bgoncal Is this something you can verify for iOS?

@bgoncal
Copy link
Member

bgoncal commented Jun 25, 2024

I didnt have time to validate that yet, but just looking at the docs it should be the same case for iOS https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors

Screenshot 2024-06-25 at 09 22 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants