Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python rflink to 0.0.66 #110060

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Update python rflink to 0.0.66 #110060

merged 6 commits into from
Feb 12, 2024

Conversation

Minims
Copy link
Contributor

@Minims Minims commented Feb 8, 2024

Proposed change

GitHub diff: aequitas/python-rflink@0.0.65...0.0.66

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • Used to manage new data WIND from last R51 release
  • This PR fixes wind sensors in rflink R51.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Used to manage new data WIND from last R51 release
@home-assistant
Copy link

home-assistant bot commented Feb 8, 2024

Hey there @javicalle, mind taking a look at this pull request as it has been labeled with an integration (rflink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rflink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign rflink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@javicalle
Copy link
Contributor

Changelog:
aequitas/python-rflink@0.0.65...0.0.66

@javicalle
Copy link
Contributor

javicalle commented Feb 9, 2024

You need to run the script:

python3 -m script.gen_requirements_all

Or you can update the requirements_all.txt file.

@Minims
Copy link
Contributor Author

Minims commented Feb 9, 2024

@javicalle i have updated the requirements

@javicalle
Copy link
Contributor

javicalle commented Feb 9, 2024

It seems that the requirements_test_all.txt must be also updated (and maybe others).

EDIT: that would be enough (see PR #89601)

@Minims
Copy link
Contributor Author

Minims commented Feb 9, 2024

It seems that the requirements_test_all.txt must be also updated (and maybe others).

EDIT: that would be enough (see PR #89601)

It might be OK now i hope.

Copy link
Contributor

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecode
Copy link
Member

thecode commented Feb 9, 2024

image
Is there an open bug here or upstream regarding this? it would be good to link it to the PR description

@Minims
Copy link
Contributor Author

Minims commented Feb 9, 2024

image Is there an open bug here or upstream regarding this? it would be good to link it to the PR description

PR on python-rflink: aequitas/python-rflink#75
Issue on RFLINK forum: https://www.letscontrolit.com/forum/viewtopic.php?p=68108#p68108

@Minims
Copy link
Contributor Author

Minims commented Feb 12, 2024

@balloob Do you need something else for this PR to be reviewed ? Thx :-)

@thecode
Copy link
Member

thecode commented Feb 12, 2024

@Minims don't tag people into the PR unless they are already a part of the conversation. I don't see why you tagged that specific person.
PR description is still missing some information, I edited it and added the information, please make sure to include the diff link / release notes on the PR description.

@thecode thecode merged commit f792690 into home-assistant:dev Feb 12, 2024
53 checks passed
@Minims
Copy link
Contributor Author

Minims commented Feb 12, 2024

@thecode sorry for that, i tag him because he has reviewed the last PR about RFlink.

Many thanks !

@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants