Update rfxtrx library to handle connection retries #111366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Danielhiversen, @RobBie1221, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
elupus
changed the title
jpbede
reviewed
Feb 26, 2024
|
Thanx! |
| if isinstance(event, rfxtrxmod.ConnectionLost): | ||
| _LOGGER.warning("Connection was lost, triggering reload") | ||
| hass.async_create_task( | ||
| hass.config_entries.async_reload(entry.entry_id), |
There was a problem hiding this comment.
We have hass.config_entries.async_schedule_reload now.
core/homeassistant/config_entries.py
Line 1576 in 9e2db70
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Upgrade rfxtrx library to one that leaves reconnection to home assistant and handle loss of connection by reloading the integration.
https://github.com/Danielhiversen/pyRFXtrx/releases/tag/0.31.0
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: