Skip to content

Commit

Permalink
Revert "Add shortcut hint to assist dialog" (#23918)
Browse files Browse the repository at this point in the history
Revert "Add shortcut hint to assist dialog (#23739)"

This reverts commit d121b33.
  • Loading branch information
wendevlin authored Jan 28, 2025
1 parent cc48ae8 commit f8d2560
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 19 deletions.
12 changes: 1 addition & 11 deletions src/dialogs/voice-command-dialog/ha-voice-command-dialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import { haStyleDialog } from "../../resources/styles";
import type { HomeAssistant } from "../../types";
import { documentationUrl } from "../../util/documentation-url";
import type { VoiceCommandDialogParams } from "./show-ha-voice-command-dialog";
import "../../components/ha-tip";

@customElement("ha-voice-command-dialog")
export class HaVoiceCommandDialog extends LitElement {
Expand All @@ -52,8 +51,6 @@ export class HaVoiceCommandDialog extends LitElement {

@state() private _errorLoadAssist?: "not_found" | "unknown";

@state() private _hint?: string;

private _startListening = false;

public async showDialog(
Expand All @@ -71,7 +68,6 @@ export class HaVoiceCommandDialog extends LitElement {

this._startListening = params.start_listening;
this._opened = true;
this._hint = params.hint;
}

public async closeDialog(): Promise<void> {
Expand Down Expand Up @@ -189,9 +185,6 @@ export class HaVoiceCommandDialog extends LitElement {
size="large"
></ha-circular-progress>
</div>`}
${this._hint
? html`<ha-tip .hass=${this.hass}>${this._hint}</ha-tip>`
: nothing}
</ha-dialog>
`;
}
Expand Down Expand Up @@ -254,7 +247,7 @@ export class HaVoiceCommandDialog extends LitElement {
css`
ha-dialog {
--mdc-dialog-max-width: 500px;
--mdc-dialog-max-height: 550px;
--mdc-dialog-max-height: 500px;
--dialog-content-padding: 0;
}
ha-dialog-header a {
Expand Down Expand Up @@ -319,9 +312,6 @@ export class HaVoiceCommandDialog extends LitElement {
margin: 0 24px 16px;
min-height: 399px;
}
ha-tip {
padding-bottom: 16px;
}
`,
];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const loadVoiceCommandDialog = () => import("./ha-voice-command-dialog");
export interface VoiceCommandDialogParams {
pipeline_id: "last_used" | "preferred" | string;
start_listening?: boolean;
hint?: string;
}

export const showVoiceCommandDialog = (
Expand All @@ -32,7 +31,6 @@ export const showVoiceCommandDialog = (
pipeline_id: dialogParams.pipeline_id,
// Don't start listening by default for web
start_listening: dialogParams.start_listening ?? false,
hint: dialogParams.hint,
},
});
};
7 changes: 1 addition & 6 deletions src/panels/lovelace/hui-root.ts
Original file line number Diff line number Diff line change
Expand Up @@ -730,12 +730,7 @@ class HUIRoot extends LitElement {
}

private _showVoiceCommandDialog(): void {
showVoiceCommandDialog(this, this.hass, {
pipeline_id: "last_used",
hint: this.hass.enableShortcuts
? this.hass.localize("ui.tips.key_a_hint")
: undefined,
});
showVoiceCommandDialog(this, this.hass, { pipeline_id: "last_used" });
}

private _handleEnableEditMode(ev: CustomEvent<RequestSelectedDetail>): void {
Expand Down

0 comments on commit f8d2560

Please sign in to comment.