-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move translation fetching to gulp action #17827
Conversation
Tried to add a review comment but github wasn't working... but looks like you have a copy/paste error here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 Should we add this to the build chain as well (e.g. if token is defined, fetch from Lokalise, otherwise fetch from nightly)?
Not sure, the nightly translations will be optimised for core, and they take the longest. |
Nightly fails on this branch: https://github.com/home-assistant/frontend/actions/runs/6088732401/job/16520013697#step:6:21
Yeah doesn't really matter I guess. Only advantage is to save a step in the nightly and release actions. |
Fixed: https://github.com/home-assistant/frontend/actions/runs/6090040013/job/16524082942#step:6:25 Translations went from 9.89 MB to 3.38 MB 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6MB off the translations tarball 🎉
Proposed change
Moved the translation fetching to gulp with the node api from Lokalise.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: