-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script change icon #20885
Script change icon #20885
Conversation
WalkthroughWalkthroughThe recent changes introduce support for renaming both automations and scripts, including an icon picker for scripts. Updates include modifications to method signatures, parameter types, and the addition of new properties and imports to handle the specific requirements of scripts. These enhancements ensure a more unified and flexible approach to managing automations and scripts within the application. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (5)
Additional Context UsedBiome (43)
Additional comments not posted (13)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@karwosts I added back the icon to the rename dialog so user can edit the icon from config using the UI. |
ba926b5
to
05f084b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
Should we rename |
Proposed change
Following #20791, add script icon to the rename dialog.
We should find a way to sync yaml alias, icon and script with entity registry in the future.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit
New Features
Enhancements
Localization