Change update logic in ha-data-table

[bramkragten]

Proposed change

Takes the grouping part out of the filtering and sorting and makes it a memoized function

Forces an update if there has not been an update for 500 ms, but there have been multiple requests, so that the data updates at least every 500 ms.

Fixes #21001
Fixes #21530

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

Summary by CodeRabbit

• New Features

  • Enhanced data handling in the HaDataTable component for improved efficiency.
  • Introduced a new state variable to track the last update time.
  • Updated grouping logic to better manage and display filtered data.

• Bug Fixes

  • Refined update logic to prevent unnecessary data refreshes, ensuring accurate display based on user interactions.

[coderabbitai]

Walkthrough

Walkthrough

The changes to the HaDataTable component involve the introduction of a new state variable _lastUpdate and the renaming of curRequest to _curRequest. The data update logic has been refined to check _filteredData for updates, and the _groupData method has been modified to improve modularity and readability. The rendering logic now derives items from the updated _groupData method, ensuring accurate data representation.

Changes

File	Change Summary
src/components/data-table/ha-data-table.ts	Renamed curRequest to _curRequest; introduced _lastUpdate state variable; modified _groupData method for improved logic and parameters.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HaDataTable
    participant DataSource

    User->>HaDataTable: Request data
    HaDataTable->>DataSource: Fetch data
    DataSource-->>HaDataTable: Return data
    HaDataTable->>HaDataTable: Process data
    HaDataTable->>User: Display updated data

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2f9b6d0 and eb1fcdc.

Files selected for processing (1)

• src/components/data-table/ha-data-table.ts (11 hunks)

Additional context used

Biome

src/components/data-table/ha-data-table.ts

[error] 678-678: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

Additional comments not posted (9)

src/components/data-table/ha-data-table.ts (9)

180-180: LGTM!

The code change is approved.

---

182-182: LGTM!

The code change is approved.

---

209-211: LGTM!

The code change is approved.

---

294-294: LGTM!

The code change is approved.

---

300-300: LGTM!

The code change is approved.

---

467-475: LGTM!

The code change is approved.

---

Line range hint 610-629: LGTM!

The code changes are approved.

---

651-658: LGTM!

The code changes are approved.

---

660-746: LGTM!

The changes to the _groupData method are approved. The encapsulation of the grouping logic and the addition of parameters improve the modularity and flexibility of the method.

Tools

Biome

[error] 678-678: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[Mariusthvdb]

as discussed with Bram in Discord: this does not fix the 2 issues yet running 2024.9.0b5
guess they need to be reopened again...