Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink title space on mobile if needed #21878

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Sep 4, 2024

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Summary by CodeRabbit

  • New Features

    • Improved styling for the main title in the HassSubpage component, allowing for better adaptability in various display scenarios.
  • Bug Fixes

    • Enhanced layout behavior of the title element, particularly in flexbox contexts, ensuring a more responsive design.

Copy link
Contributor

coderabbitai bot commented Sep 4, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The change introduces a new CSS property min-width: 0; to the .main-title class in the HassSubpage component. This modification allows the main title element to have a minimum width of zero, which can influence its layout behavior, particularly in flexbox contexts. The overall functionality of the component remains unchanged.

Changes

Files Change Summary
src/layouts/hass-subpage.ts Added min-width: 0; to the .main-title class to allow for reduced width in flexbox contexts.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HassSubpage
    participant MainTitle

    User->>HassSubpage: Load page
    HassSubpage->>MainTitle: Render main title
    MainTitle->>HassSubpage: Apply styles
    Note right of MainTitle: min-width: 0 applied
    HassSubpage->>User: Display page with main title
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@silamon silamon modified the milestone: 2024.9 Sep 5, 2024
@silamon
Copy link
Contributor

silamon commented Sep 5, 2024

Shouldn't we work with text-overflow here? Now the edit marker is placed upon the text.

@piitaya
Copy link
Member Author

piitaya commented Sep 5, 2024

@silamon I don't think we can because the text is multiline 🙁

@Sereby88
Copy link

Why not shrinking the font size with something like this to fit the space?

https://stackoverflow.com/questions/11777598/font-size-relative-to-the-users-screen-resolution

@silamon silamon marked this pull request as draft September 21, 2024 11:08
@piitaya
Copy link
Member Author

piitaya commented Oct 16, 2024

Why not shrinking the font size with something like this to fit the space?

https://stackoverflow.com/questions/11777598/font-size-relative-to-the-users-screen-resolution

It can lead to accessibility issue because of a small font-size. Also font-size should be fixed for consistency across screens.

@piitaya piitaya marked this pull request as ready for review October 29, 2024 08:28
@wendevlin
Copy link
Contributor

@piitaya what about add word-break: break-all; just if the title has no space in it?

@home-assistant home-assistant bot marked this pull request as draft October 29, 2024 09:06
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@piitaya piitaya marked this pull request as ready for review October 29, 2024 09:26
@wendevlin wendevlin enabled auto-merge (squash) October 29, 2024 09:30
@wendevlin wendevlin merged commit 5f58ac4 into dev Oct 29, 2024
11 checks passed
@wendevlin wendevlin deleted the fix_title_action_long_text branch October 29, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit of Device not possible when name to long
4 participants