-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink title space on mobile if needed #21878
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe change introduces a new CSS property Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HassSubpage
participant MainTitle
User->>HassSubpage: Load page
HassSubpage->>MainTitle: Render main title
MainTitle->>HassSubpage: Apply styles
Note right of MainTitle: min-width: 0 applied
HassSubpage->>User: Display page with main title
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Shouldn't we work with text-overflow here? Now the edit marker is placed upon the text. |
@silamon I don't think we can because the text is multiline 🙁 |
Why not shrinking the font size with something like this to fit the space? https://stackoverflow.com/questions/11777598/font-size-relative-to-the-users-screen-resolution |
It can lead to accessibility issue because of a small font-size. Also font-size should be fixed for consistency across screens. |
@piitaya what about add |
6112514
to
38526cc
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Wendelin <[email protected]>
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit
New Features
Bug Fixes