-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to move card from other view to section view #22399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition,
Would be cool if this could also use the undo
notification like in your other PR for deleting.
In a seperate PR we should add the possibility to move a card form a sections view back to masonry.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@wendevlin Or just move a card from one section view to another view. I agree 👍 |
3e0b8cf
to
c167f0d
Compare
c167f0d
to
169a5f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piitaya would you like to add the undo notification too?
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Wendelin <[email protected]>
Proposed change
Allow to move card to a "sections" view. It will create a new section with dedicated title.
The heading of the section is used to know if we need to create another section or use the existing one when moving.
I first tested to add metadata to the section config but it wasn't a good solution as the user can reuse the section in the dashboard. That will end up with adding moved card to this reused section.
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: