Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Wifi configuration UI #22471

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Improve Wifi configuration UI #22471

merged 4 commits into from
Oct 24, 2024

Conversation

MindFreeze
Copy link
Contributor

Proposed change

  • Disable IP configuration until wifi network is selected
  • Deduplicate wifi networks by name and show only the one with the strongest signal
  • Reload IP configuration after save to show current IP
  • Add clear button that resets the form to defaults and removes the wifi network. Essentially allowing to forget a network

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze marked this pull request as ready for review October 22, 2024 07:56
@matthiasdebaat
Copy link
Collaborator

CleanShot 2024-10-22 at 09 58 05@2x

A couple of suggestions:

  • If there is no WiFi network connected, drop the IPv4 and IPv6 collapsibles.
  • Move the "Clear" button to the W-Fi collapsible for better context.
  • Change the clear button label to "Forget network"
  • Change the "Scan for access points" label to "Search networks" as this is more common terminology.
  • Move the W-Fi collapsible to the top, as the IP addresses are based on this selection.

@MindFreeze
Copy link
Contributor Author

Thr clear button is not just about forgetting. It also sets everything to auto. It is there for ethernet as well.
Will implement the rest

@MindFreeze MindFreeze marked this pull request as draft October 22, 2024 08:08
@MindFreeze
Copy link
Contributor Author

image

@MindFreeze MindFreeze marked this pull request as ready for review October 22, 2024 09:51
@piitaya
Copy link
Member

piitaya commented Oct 22, 2024

Just a question : should the button be "Reset configuration" or something like that? I can not figure what the button will do with a "clear" label. If the text is too long, it can be in a overflow, right?

@MindFreeze
Copy link
Contributor Author

I tried "reset to defaults" but I didn't like it. "Reset configuration" is better. I'll use that

piitaya
piitaya previously approved these changes Oct 23, 2024
Comment on lines 616 to 619
// mock
if (this._interface?.wifi) {
// this._interface!.wifi!.ssid = undefined;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed, right?

Copy link
Contributor

coderabbitai bot commented Oct 24, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MindFreeze MindFreeze enabled auto-merge (squash) October 24, 2024 08:09
@MindFreeze MindFreeze merged commit fc9a095 into home-assistant:dev Oct 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants