Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading spinner when waiting for backups (re)load #22485

Merged

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Oct 22, 2024

Proposed change

Show a loading spinner while waiting for backups to load. Especially when using network shares, loading backups can take a few seconds. The data table would then display “You don't have any backups yet.”, even though there are backups.

Instead, a loading spinner is now displayed to show that the backups are being loaded.

Also refreshData has been removed, it only calls fetchBackups with an additional reloadHassioBackups (which is also called in fetchBackups, so it is called twice)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Supervisor Related to the supervisor panel label Oct 22, 2024
@MindFreeze MindFreeze merged commit 3e0c998 into home-assistant:dev Oct 29, 2024
17 checks passed
@jpbede jpbede deleted the hassio-backups-loading-spinner branch October 29, 2024 08:36
@uberchris2
Copy link

Thank you @jpbede !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hacktoberfest Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No loading indicator for backups
3 participants