Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #22450: Corrected two inaccurate messages #22496

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

shodhan-rai
Copy link
Contributor

Proposed change

This PR rewords two messages in the System > Repairs section to better reflect their context. The changes are as follows:

  1. The message "There are currently no repairs available" is changed to "There are currently no repairs pending."
  2. The message "Integration startup time" remains unchanged as no modifications were made to it.

These updates enhance clarity for users regarding the status of repairs and improve user experience.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shodhan-rai

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@shodhan-rai shodhan-rai marked this pull request as ready for review October 23, 2024 13:38
@silamon
Copy link
Contributor

silamon commented Oct 23, 2024

Thank you!

@silamon silamon enabled auto-merge (squash) October 23, 2024 14:00
@silamon silamon merged commit 3a1a4ad into home-assistant:dev Oct 23, 2024
11 checks passed
@NoRi2909
Copy link

@silamon Thanks for the quick fix. I just noticed that there two more (probably orphaned) strings with "Integration startup time" in this block:

"system_health": {
"caption": "System health",
"description": "Status, metrics, and integration startup time",
"cpu_usage": "Processor usage",
"ram_usage": "Memory usage",
"core_stats": "Core metrics",
"supervisor_stats": "Supervisor metrics",
"integration_start_time": "Integration startup time"
},

As they are no longer in that respective window (moved to the one we fixed the strings for above) I assume that the keys

description and integration_start_time can both be removed here, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings > Repairs: Fix two inaccurate messages
3 participants