Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timespans to logbook, energy and history #23362

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

boern99
Copy link
Contributor

@boern99 boern99 commented Dec 20, 2024

Breaking change

Proposed change

Type of change

adds som additional Date-Selections: Last 24 hours, Last 30 days and Last 365 days to History, Logbook and Energy-Dashbaord
image

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added the Needs UX Pull requests requiring a review from the Home Assistant design team label Dec 22, 2024
@kobuki
Copy link

kobuki commented Jan 12, 2025

Could you please also add back the "Yesterday", "Last week", "Last month" and "Last year" selectors as well as it used to be? Up to 2024.12 it was also present with the ones you to propose to add back. In 2024.12 and earlier all were there. Many times we're curious about full calendar units, not just the time span ending in the current point in time. My issue in the subject: #23671. Similar issues affecting the same UI component: #23685, #23685.

Reference:

image

@boern99
Copy link
Contributor Author

boern99 commented Jan 12, 2025

Could you please also add back the "Yesterday", "Last week", "Last month" and "Last year" selectors as well as it used to be? Up to 2024.12 it was also present with the ones you to propose to add back. In 2024.12 and earlier all were there. Many times we're curious about full calendar units, not just the time span ending in the current point in time. My issue in the subject: #23671. Similar issues affecting the same UI component:

The Idea was, that you simple can use Today and click the back button for yesterday: once more you would also have the day before yesterday and so forth. This works also for Week, Month, and Year. Removing "Yesterday", "Last week", "Last month" and "Last year" gives enough space for additional options: last 24h, last 30days, last 365days and keeps the list clear.

@kobuki
Copy link

kobuki commented Jan 12, 2025

The Idea was, that you simple can use Today and click the back button for yesterday: once more you would also have the day before yesterday and so forth. This works also for Week, Month, and Year.

Well, that makes sense. One more mouse click/tap, tho...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Needs UX Pull requests requiring a review from the Home Assistant design team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants