Allow to change encryption for each backup location #23861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
added
Backend Change Required
piitaya
force-pushed
the
backup_location_settings
branch
from
0b90ef7 to
78755fb
Compare
NoRi2909
suggested changes
Jan 27, 2025
piitaya
added
wait for backend
and removed
Backend Change Required
NoRi2909
reviewed
Jan 27, 2025
bramkragten
reviewed
Jan 28, 2025
bramkragten
reviewed
Jan 28, 2025
bramkragten
reviewed
Jan 28, 2025
piitaya
force-pushed
the
backup_location_settings
branch
from
75871cf to
d9a3a86
Compare
bramkragten
reviewed
Jan 28, 2025
piitaya
force-pushed
the
backup_location_settings
branch
from
4115569 to
8e2afc4
Compare
bramkragten
reviewed
Jan 29, 2025
piitaya
added
backend merged
piitaya
force-pushed
the
backup_location_settings
branch
from
0c7a82e to
d60412d
Compare
bramkragten
approved these changes
Jan 29, 2025
wendevlin
requested changes
Jan 29, 2025
|
|
||
| private async _fetchAgent() { | ||
| try { | ||
| // Todo fetch agent details |
There was a problem hiding this comment.
Suggested change
| // Todo fetch agent details |
This todo seems to be done
| ? html` | ||
| <div slot="supporting-text"> | ||
| <span class="dot warning"></span> | ||
| <span> Unencrypted </span> |
| : html` | ||
| <div slot="supporting-text"> | ||
| <span class="dot success"></span> | ||
| <span> Encrypted </span> |
Comment on lines
+277
to
+298
| ? html` | ||
| <div slot="supporting-text"> | ||
| <span class="dot error"></span> | ||
| <span> | ||
| ${this.hass.localize( | ||
| "ui.panel.config.backup.details.locations.backup_failed" | ||
| )} | ||
| </span> | ||
| </div> | ||
| ` | ||
| : unencrypted | ||
| ? html` | ||
| <div slot="supporting-text"> | ||
| <span class="dot warning"></span> | ||
| <span> Unencrypted </span> | ||
| </div> | ||
| ` | ||
| : html` | ||
| <div slot="supporting-text"> | ||
| <span class="dot success"></span> | ||
| <span> Encrypted </span> | ||
| </div> |
There was a problem hiding this comment.
div and dot is always there, I would suggest a condition for the span class and for the text
| })} | ||
| crossorigin="anonymous" | ||
| referrerpolicy="no-referrer" | ||
| alt="" |
There was a problem hiding this comment.
Can we add here the agent name and logo?
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Allow to change encryption for each backup location (except Cloud for privacy concern).
Screenshots
Backup settings (locations)
Location settings (encrypted)
Location settings (unencrypted)
Cloud location settings
Backup detail (locations list)
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: