Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view header #24237

Open
wants to merge 33 commits into
base: dev
Choose a base branch
from
Open

Add view header #24237

wants to merge 33 commits into from

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Feb 14, 2025

Proposed change

CleanShot 2025-02-14 at 17 34 30@2x

Add heading section to allow user to place badges and text with template and markdown support at the top of the view.

Features :

  • optional heading text with markdown and template support
  • optional badges
  • 3 layouts :
    • Responsive (default)
    • Always left align
    • Always center align
  • 2 badges position :
    • bottom, below text (default)
    • top, above text
  • option to add extra top margin.

Migration

Badges from sections view will be migrated to this new section.

Things that still need to be done :

  • Create new title/text card instead of using the current markdown card (another PR)
  • Improve section editor
  • Documentation (for later as some implementation details still need to be discussed)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added the Do Not Review PR is not ready for any kind of review label Feb 14, 2025
@piitaya piitaya force-pushed the heading_section branch 3 times, most recently from 702de26 to 295915b Compare February 17, 2025 14:56
@piitaya piitaya added Documentation Needed Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) and removed Do Not Review PR is not ready for any kind of review labels Feb 17, 2025
@piitaya piitaya marked this pull request as ready for review February 17, 2025 16:38
@piitaya piitaya force-pushed the heading_section branch 2 times, most recently from 4c14308 to c580876 Compare February 19, 2025 15:33
@piitaya piitaya marked this pull request as draft February 19, 2025 16:51
@piitaya piitaya changed the title Add heading section Add view header Feb 19, 2025
@piitaya piitaya force-pushed the heading_section branch 7 times, most recently from 0773e65 to a0b96e2 Compare February 20, 2025 11:05
@piitaya piitaya marked this pull request as ready for review February 20, 2025 14:16
@silamon
Copy link
Contributor

silamon commented Feb 20, 2025

I've had the width of the card jumping further to the right though when I had no badges anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants