Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve edit card dialog user experience #24275

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Feb 17, 2025

Proposed change

Improve the edit card dialog user experience based on the Figma design from @marcinbauer85 in #22509.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile with a tall card (history-card with a lot of charts) the options are not acessible. I only see the card preview

@jpbede
Copy link
Member Author

jpbede commented Feb 20, 2025

Yea, saw that yesterday as well, will check with @marcinbauer85

@MindFreeze MindFreeze marked this pull request as draft February 20, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants