Push map strategy logic down into map card #24303
Open
+52
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MindFreeze
reviewed
Feb 20, 2025
MindFreeze
added
the
Noteworthy
karwosts
commented
Feb 20, 2025
| ? processConfigEntities<MapEntityConfig>(config.entities) | ||
| if (config.show_all && (config.entities || config.geo_location_sources)) { | ||
| throw new Error( | ||
| "Cannot specify show_all and entities or geo_location_sources" |
There was a problem hiding this comment.
I considered if this should be allowed (like if you want to show_all and additionally apply some custom config to a specific entity), but it got a little confusing with the mix of entities and geo_sources, and I'm not sure if there is demand for this, so I punted for now for simplicity.
karwosts
commented
Feb 20, 2025
| } | ||
| this._config = { ...config }; | ||
| if (this.hass && config.show_all) { | ||
| this._config.entities = this._getAllEntities(); |
There was a problem hiding this comment.
Feels a bit odd but I guess there's nothing wrong with a card modifying its own config?
I think this is needed so hasConfigOrEntitiesChanged tracks these auto-entities correctly.
Sure, will PR once the functionality is agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR pushes the special logic for the map strategy (auto-show all entities) into a new option in map card (
show_all).This allows user to take control of map panel without losing any features. Currently once you take control of the map panel, the list of entities becomes frozen in time, and user has to then manually update any future added persons or zones, which is not ideal.
This makes it easier to customize the map panel (e.g. add history tracing lines) without compromise.
Also I might follow up to add an option to unfocus the home zone (to go back to 2025.1 behavior), and that would be another reason to take control of map dashboard.
The other direction this could go would be to just add more options to the map strategy via a custom dialog without having the user take control, but that just seems like we will forever have to implement all map features in two places; and users will complain any time the features diverge between the two. Seems like it makes sense to just have one way to configure map features (via editing the card).
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: