Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix siren advanced controls #24318

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

karwosts
Copy link
Contributor

Proposed change

According to demo siren and developer docs:

  • volume should be volume_level
  • available_tones can be an array or a dict. The current code is only correctly handling dicts (I think, I don't have one). The demo siren uses an array, so this code fixes the dialog for the demo siren, I think it should work for arrays or dicts.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙂

@wendevlin wendevlin merged commit a68bdbf into home-assistant:dev Feb 20, 2025
15 checks passed
@karwosts karwosts deleted the fix-advanced-siren branch February 20, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Siren more-info exposes "volume", backend service uses "volume_level"
2 participants