Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hass.markdown #36608

Draft
wants to merge 3 commits into
base: current
Choose a base branch
from
Draft

Conversation

erffrfez
Copy link
Contributor

@erffrfez erffrfez commented Dec 30, 2024

add text as per issue #20086 (#20086).

also change bash to text in the markdown to remove the colour highlighting from 'exit', 'file' etc

Proposed change

This is to address the comment in the issue #20086
While here I changed the markdown to remove un-needed, and slightly distracting colour highlighting (change bash to text)

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • I've opened up a PR to add logos and icons in Brands repository.
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated documentation for the hass command-line tool
    • Clarified tool availability and usage for Home Assistant Core users
    • Changed formatting of command usage instructions from bash to text

add text as per issue home-assistant#20086  (home-assistant#20086).

also change bash to text in the markdown to remove the colour highlighting from 'exit', 'file' etc
@home-assistant home-assistant bot added the current This PR goes into the current branch label Dec 30, 2024
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 8d6287b
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6778d75fa51e650008e0da79
😎 Deploy Preview https://deploy-preview-36608--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Dec 30, 2024

📝 Walkthrough

Walkthrough

The documentation for the hass command-line tool in Home Assistant has been updated to include additional context about its availability and usage. A new explanatory sentence clarifies that the tool is exclusively for Home Assistant Core users, is initiated from the command line on the machine running Home Assistant Core (potentially accessed via SSH), and is distinct from the Home Assistant CLI (hass-cli). The formatting of the command usage section has also been changed from a code block labeled as bash to one labeled as text.

Changes

File Change Summary
source/_docs/tools/hass.markdown - Added explanatory sentence about hass tool's availability and usage
- Changed code block formatting from bash to text

Note: No changes were made to exported or public entities in this update.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 532750f and 8d6287b.

📒 Files selected for processing (1)
  • source/_docs/tools/hass.markdown (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • source/_docs/tools/hass.markdown

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_docs/tools/hass.markdown (1)

6-7: Improve text formatting and link accessibility

The added context is valuable, but there are a few formatting improvements to consider:

-The command-line part of Home Assistant is `hass`.\
-This tool is only available to Home Assistant Core users, is started from the command line on the computer running Home Assistant Core (accessed perhaps via ssh) and is not the same as Home Assistant CLI (aka hass-cli). [link](https://www.home-assistant.io/blog/2019/02/04/introducing-home-assistant-cli/)
+The command-line part of Home Assistant is `hass`.
+
+This tool is only available to Home Assistant Core users, is started from the command line on the computer running Home Assistant Core (accessed perhaps via ssh) and is not the same as [Home Assistant CLI (hass-cli)](https://www.home-assistant.io/blog/2019/02/04/introducing-home-assistant-cli/).

Changes:

  1. Remove the unnecessary backslash
  2. Add a line break for better readability
  3. Make the link text more descriptive by incorporating it into the sentence
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb8e6d2 and 532750f.

📒 Files selected for processing (1)
  • source/_docs/tools/hass.markdown (1 hunks)
🔇 Additional comments (1)
source/_docs/tools/hass.markdown (1)

9-9: LGTM! Good choice on syntax highlighting

The change from bash to text syntax highlighting is a good improvement. It reduces distracting color highlighting for command-line terms while maintaining clear readability of the options and their descriptions.

source/_docs/tools/hass.markdown Outdated Show resolved Hide resolved
@@ -3,10 +3,10 @@ title: "hass"
description: "Description of hass."
---

The command-line part of Home Assistant is `hass`.
The command-line part of Home Assistant is `hass`.\
This tool is only available to Home Assistant Core users, is started from the command line on the computer running Home Assistant Core (accessed perhaps via ssh) and is not the same as Home Assistant CLI (aka hass-cli). [link](https://www.home-assistant.io/blog/2019/02/04/introducing-home-assistant-cli/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording adjustment.

Removed the reference of hass-cli, which is no longer part of the Home Assistant project and is a third-party tooling.

Suggested change
This tool is only available to Home Assistant Core users, is started from the command line on the computer running Home Assistant Core (accessed perhaps via ssh) and is not the same as Home Assistant CLI (aka hass-cli). [link](https://www.home-assistant.io/blog/2019/02/04/introducing-home-assistant-cli/)
This tool is only available to users of the Home Assistant Core installation method. It is started from the command line on the computer running Home Assistant Core (accessed perhaps via SSH).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In relative authority on what this thing should say, I'm so far down the list so as to not count!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not fully grasp what you mean by that response. That might be a language gap on my end. Could you clarify your wording differently?

@home-assistant
Copy link

home-assistant bot commented Jan 2, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 2, 2025 12:26
@erffrfez erffrfez marked this pull request as ready for review January 4, 2025 06:37
@home-assistant home-assistant bot requested a review from frenck January 4, 2025 06:37
@frenck frenck marked this pull request as draft January 4, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants