-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add number platform to Mill integration #36623
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request introduces a new Changes
The changes are minimal but significant, enhancing the integration's documentation and configurability for Mill heaters in Home Assistant. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/mill.markdown (1)
25-25
: Enhance the number entity documentationWhile the basic functionality is documented, users would benefit from more detailed information about:
- The available value range for maximum power
- The unit of measurement (watts, percentage, etc.)
- Whether this setting persists across restarts
Consider expanding the documentation with a dedicated section like this:
+## Number + +The integration provides a number entity to configure the maximum power of each heater: + +| Entity | Description | +| ------ | ----------- | +| `number.mill_[device_name]_max_power` | Controls the maximum power setting. Values range from X to Y [unit]. |
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/mill.markdown
(2 hunks)
🔇 Additional comments (2)
source/_integrations/mill.markdown (2)
15-15
: LGTM: Platform addition follows documentation standards
The addition of the number
platform to ha_platforms
is correctly formatted and aligned with the new feature.
24-24
: LGTM: Improved grammar
The addition of the period improves readability and maintains consistent punctuation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation