Adds config option exclude_errors (#342) #443
Conversation
| |> Notice.new(metadata_with_breadcrumbs, stacktrace, fingerprint) | ||
| |> put_notice_fingerprint() | ||
|
|
||
| exclude_error_value = Application.get_env(:honeybadger, :exclude_errors) |
There was a problem hiding this comment.
Fetching the exclude_error using compile_env/2 results to the following error:
ERROR! the application :honeybadger has a different value set for key :exclude_errors during runtime compared to compile time. Since this application environment entry was marked as compile time, this difference can lead to different behaviour than expected:
* Compile time value was not set
* Runtime value was set to: []
To fix this error, you might:
* Make the runtime value match the compile time one
* Recompile your project. If the misconfigured application is a dependency, you may need to run "mix deps.compile honeybadger --force"
* Alternatively, you can disable this check. If you are using releases, you can set :validate_compile_env to false in your release configuration. If you are using Mix to start your system, you can pass the --no-validate-compile-env flag
** (ErlangError) Erlang error: "aborting bo
From the error it suggests we have set a runtime option. Does that mean we also need to set a compile option ? cc @sorentwo
There was a problem hiding this comment.
It would have to be referenced in the module body, outside of a function. Don't worry about it, there are several places where we're referencing the application environment during runtime. It's just not a recommended practice.
|
This also need a changelog entry. |
Co-authored-by: Joshua Wood <[email protected]>
| |> Notice.new(metadata_with_breadcrumbs, stacktrace, fingerprint) | ||
| |> put_notice_fingerprint() | ||
|
|
||
| exclude_error_value = Application.get_env(:honeybadger, :exclude_errors) |
There was a problem hiding this comment.
It would have to be referenced in the module body, outside of a function. Don't worry about it, there are several places where we're referencing the application environment during runtime. It's just not a recommended practice.
|
@TraceyOnim This just needs documentation in the readme. |
Hey @TraceyOnim, are you working on this? |
|
Yes, I'm working on it
…On Wed, 19 Oct 2022, 14:45 Pangratios Cosma, ***@***.***> wrote:
@TraceyOnim <https://github.com/TraceyOnim> This just needs documentation
in the readme. cc @subzero10 <https://github.com/subzero10>
Hey @TraceyOnim <https://github.com/TraceyOnim>, are you working on this?
—
Reply to this email directly, view it on GitHub
<#443 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKKCLKNOHMVPI2U7FROUNQLWD7NOBANCNFSM55M5FB7A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…lixir into restore-342
Hey @subzero10, README is now ready |
Co-authored-by: Pangratios Cosma <[email protected]>
This branch restores #342. See the original PR for summary and initial discussion.
Let's continue discussion on this new PR.