feat: compress kept trace decision message #1430
Open
+287
−92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Due to the multiplication effect of pubsub messages through Redis, we would like to bring down the amount of network traffic sent by Redis.
One of the biggest contributors is
TraceDecison
message used to communicate kept trace decisions.This PR uses
snappy
to compress the data and then encoded usinggob
Here's the benchmark results comparing to the original JSON encoding.
In the
BenchmarkCompressionSizes
test, I generated a batch of 1000 trace decisions as the input. The amount of decrease in data size is 90%I also used
sync.Pool
for both compression and decompression buffers as well assnappy.Writer
to reduce allocation