ci: Use latest version of Bun and Deno for CI #3554
Conversation
build/build.ts
Outdated
| @@ -58,7 +58,6 @@ const addExtension = (extension: string = '.js', fileExtension: string = '.ts'): | |||
| }) | |||
|
|
|||
| const commonOptions: BuildOptions = { | |||
| watch: isWatch, | |||
There was a problem hiding this comment.
I added this because this line causes error Invalid option in build() call: "watch".
I couldn't find that Bun docs referring to the watch option, and its only suggestion is to use --watch option in command.
There was a problem hiding this comment.
I can't get the error. How can I reproduce it? The watch is for esbuild, unrelated to the Bun.
There was a problem hiding this comment.
Hmm... Probably it is a bug related Bun caching.
I will push the branch again without those changes. I guess the CI can catch the error.
|
Can you fix the CI error? |
fel1x-developer
force-pushed
the
patch-1
branch
3 times, most recently
from
6213af0
to
31fae48
Compare
|
setup-bun does not support |
yusukebe
changed the title
fel1x-developer
force-pushed
the
patch-1
branch
from
31fae48
to
7560a70
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3554 +/- ##
==========================================
- Coverage 94.71% 89.74% -4.98%
==========================================
Files 158 158
Lines 9552 10080 +528
Branches 2825 2921 +96
==========================================
- Hits 9047 9046 -1
- Misses 505 1034 +529 ☔ View full report in Codecov by Sentry. |
|
It passed! Thank you very much. I'll merge this now. |
The author should do the following, if applicable
jsxImport bug in Bun appeared in 1.1.28, fixed in 1.1.33
Update
oven-sh/setup-bunto v2Use Bun
1.1.xUpdate
denoland/setup-denoto v2Use
jsr:@david/[email protected]Add tests
Run tests
bun run format:fix && bun run lint:fixto format the codeAdd TSDoc/JSDoc to document the code