Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils/crypto): fix types of crypto utility #3614

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Nov 2, 2024

Related: #3604 (comment)

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@EdamAme-x EdamAme-x marked this pull request as draft November 2, 2024 11:40
@EdamAme-x
Copy link
Contributor Author

The test will pass when the associated PRs are merged

@yusukebe
Copy link
Member

yusukebe commented Nov 4, 2024

@EdamAme-x

Can you update this?

@EdamAme-x EdamAme-x marked this pull request as ready for review November 4, 2024 03:38
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (22db73f) to head (55e4acd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3614   +/-   ##
=======================================
  Coverage   89.80%   89.80%           
=======================================
  Files         159      159           
  Lines       10120    10120           
  Branches     2900     2828   -72     
=======================================
  Hits         9088     9088           
  Misses       1032     1032           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdamAme-x
Copy link
Contributor Author

@yusukebe Ready

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Nov 4, 2024

@EdamAme-x

Thank you!

@yusukebe yusukebe merged commit d717a4f into honojs:main Nov 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants